cli: move flag definitions to a separate package (cli refactor sequence 6/n)#82141
Merged
craig[bot] merged 5 commits intomasterfrom May 31, 2022
Merged
cli: move flag definitions to a separate package (cli refactor sequence 6/n)#82141craig[bot] merged 5 commits intomasterfrom
craig[bot] merged 5 commits intomasterfrom
Conversation
This will be needed to ensure `cockroach-sql` supports the same env vars. Release note: None
This ensures that the basic primitives are reusable out of package `cli`. Release note: None
Release note: None
Member
|
This change is |
So that the caller can control at which level the env var consumer check occurs. (This can be explored via `cockroach debug env`.) Release note: None
Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR split from #82020 to ease review.