cockroach-sql: increase compatibility with cockroach-sql#82074
Merged
craig[bot] merged 1 commit intomasterfrom May 31, 2022
Merged
cockroach-sql: increase compatibility with cockroach-sql#82074craig[bot] merged 1 commit intomasterfrom
cockroach-sql#82074craig[bot] merged 1 commit intomasterfrom
Conversation
Member
|
This change is |
otan
approved these changes
May 30, 2022
pkg/cmd/cockroach-sql/main.go
Outdated
| } | ||
|
|
||
| // How we're going to authenticate. | ||
| usePw, _, _ := connURL.GetAuthnPassword() |
Contributor
There was a problem hiding this comment.
nit: pw as acronym, so use usePW
00eaddb to
cc7bcff
Compare
Release note (cli change): The standalone `cockroach-sql` executable now has more compatibility with `cockroach sql`, so it can be used as a drop-in replacement. For example, it supports running without a URL, using connection defaults. It also supports overriding `--certs-dir` and other client-side options also supported by `cockroach sql`.
Contributor
Author
|
(NB: Holding off on merging this despite the review approval, since we can't merge intermediate PRs in a sequence without dropping the entire sequence off github.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR split from #82020 to ease review.
Fixes #81882.
Fixes #82024.
Release note (cli change): The standalone
cockroach-sqlexecutablenow has more compatibility with
cockroach sql, so it can be used asa drop-in replacement. For example, it supports running without a URL,
using connection defaults. It also supports overriding
--certs-dirand other client-side options also supported by
cockroach sql.