cli: move URL override logic to a separate package (cli refactor sequence 3/n)#82070
Merged
craig[bot] merged 7 commits intomasterfrom May 31, 2022
Merged
cli: move URL override logic to a separate package (cli refactor sequence 3/n)#82070craig[bot] merged 7 commits intomasterfrom
craig[bot] merged 7 commits intomasterfrom
Conversation
Member
|
This change is |
3629d0c to
f09168d
Compare
Contributor
Author
|
the last commit introduces an interface as requested by @otan here #82020 (comment) |
otan
approved these changes
May 30, 2022
Contributor
Author
|
(NB: Holding off on merging this despite the review approval, since we can't merge intermediate PRs in a sequence without dropping the entire sequence off github.) |
This is one step towards lifting client_url to a different package. Release note: None
This is one step towards lifting client_url to a different package. Release note: None
This is one step towards lifting client_url to a different package. Release note: None
This is one step towards lifting client_url to a different package. Release note: None
This is one step towards lifting client_url to a different package. Release note: None
This is one step towards lifting client_url to a different package. Release note: None
…tURL() This documents the API semantics makes the code slightly easier to reason about. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR split from #82020 to ease review.