Skip to content

security: move AssetLoader to a separate package#82021

Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom
knz:20220528-assetloader
May 30, 2022
Merged

security: move AssetLoader to a separate package#82021
craig[bot] merged 3 commits intocockroachdb:masterfrom
knz:20220528-assetloader

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented May 28, 2022

First commit from #82019.
This PR is a prerequisite of #82020 to fix #81882.

This is leftover work from cockroachdb#81298.

Release note: None
@knz knz requested review from a team, rimadeodhar and stevendanna May 28, 2022 18:51
@knz knz requested review from a team as code owners May 28, 2022 18:51
@knz knz requested review from a team May 28, 2022 18:51
@knz knz requested a review from a team as a code owner May 28, 2022 18:51
@knz knz requested review from a team May 28, 2022 18:51
@knz knz requested review from a team as code owners May 28, 2022 18:51
@knz knz requested a review from a team May 28, 2022 18:51
@knz knz requested review from a team as code owners May 28, 2022 18:51
@knz knz requested a review from a team May 28, 2022 18:51
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@knz knz changed the title seurity: move AssetLoader to a separate package security: move AssetLoader to a separate package May 28, 2022
@knz
Copy link
Copy Markdown
Contributor Author

knz commented May 30, 2022

I'll take your advice from #82020 (comment) and simplify the name(s) to reduce stuttering before I merge this.

@knz knz force-pushed the 20220528-assetloader branch from f28e3c8 to 2bb800e Compare May 30, 2022 14:18
@knz
Copy link
Copy Markdown
Contributor Author

knz commented May 30, 2022

ok done
TFYR

bors r=otan

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 30, 2022

Build succeeded:

@craig craig bot merged commit 3b1d7ab into cockroachdb:master May 30, 2022
@knz knz deleted the 20220528-assetloader branch May 30, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow standalone SQL client binary to support --certs-dir

3 participants