kv/kvserver: fix flaky TestStoreMetrics#81923
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 26, 2022
Merged
Conversation
Skip TestStoreMetrics assertions about bloom filter lookups. Pebble now only consults L6 bloom filters if explicitly requested, and CockroachDB only requests their use when checking for ingested sstable collisions (see cockroachdb#81062). Release note: none Fix cockroachdb#81823.
Member
|
This change is |
nicktrav
approved these changes
May 26, 2022
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @nvanbenschoten)
Contributor
Author
|
TFTRs! bors r=nicktrav,nvanbenschoten |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip TestStoreMetrics assertions about bloom filter lookups. Pebble now
only consults L6 bloom filters if explicitly requested, and CockroachDB
only requests their use when checking for ingested sstable collisions
(see #81062).
Release note: none
Fix #81823.