ui: open TimeScaleDropdown directly to the custom menu when custom is selected#81855
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 26, 2022
Merged
Conversation
Member
|
This change is |
maryliag
approved these changes
May 26, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
looks great!
just a tiny nit, otherwise
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @1lann and @jocrl)
pkg/ui/workspaces/cluster-ui/src/timeScaleDropdown/timeScaleDropdown.spec.tsx line 207 at r1 (raw file):
); // When a preset option is selected, the dropdown should open to other preset options
small nit: add period to the end of all comments
Contributor
Author
|
TFTR! @Annebirzin, just checking that the spacing for "Preset Time Ranges" looks good? |
… selected Fixes cockroachdb#78499 This commit modifies the TimeScaleDropdown so that if a custom time is currently select it opens directly to the custom selection menu, and a "Preset Time Ranges" navigation link to go to the preset options from the custom menu. This commit also cleans up the unused DateRange component. Release note (ui): The time picker now opens directly to the custom time selection menu when a custom time is already selected. A "Preset Time Ranges" navigation link has been added to go to the preset options from the custom menu.
a798c0a to
bc10e2b
Compare
Contributor
Author
|
Added periods to comments. |
|
looks good, thanks @jocrl! |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78499
This commit modifies the TimeScaleDropdown so that if a custom time is currently
select it opens directly to the custom selection menu, and a "Preset Time
Ranges" navigation link to go to the preset options from the custom menu.
This commit also cleans up the unused DateRange component.
779475.open.directly.to.custom.when.custom.is.selected.480p.mov
Release note (ui): The time picker now opens directly to the custom time
selection menu when a custom time is already selected. A "Preset Time Ranges"
navigation link has been added to go to the preset options from the custom
menu.