build: use bazel for roachtest stress#81804
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2022
Merged
Conversation
Currently, the Roachtest Stress TeamCity job uses `make` (via the
`mkrelease.sh` script) for building the required binaries. Recently, the
pipeline started hanging while building the binary. Rather than
investigating and fixing the existing `make`-based pipeline, convert the
job to using Bazel for building the binaries.
Retain the existing entrypoint to the job, converting it to use [the
existing pattern][1] of calling `run_bazel` with the required
environment variables, invoking an `_impl.sh` script. The existing logic
is moved into the new `_impl.sh` script, with some minor additions to
source some additional scripts.
Additionally, the TeamCity job itself was updated to set pass in the
`TARGET_CLOUD` environment variable (set to `gce`), and remove the need
to build within a container (instead deferring to Bazel to manage the
build environment). The diff for the TeamCity pipeline is as follows
(for posterity):
```diff
18c18
<
---
> <param name="env.TARGET_CLOUD" value="gce" />
24c24
< <param name="plugin.docker.imageId" value="%builder.dockerImage%" />
---
>
28,29c28,29
< export BUILD_TAG="$(git describe --abbrev=0 --tags --match=v[0-9]*)"
< ./build/teamcity-roachtest-stress.sh]]></param>
---
> build_tag="$(git describe --abbrev=0 --tags --match=v[0-9]*)"
> CLOUD=${TARGET_CLOUD} BUILD_TAG="${build_tag}" ./build/teamcity-roachtest-stress.sh]]></param>
```
Release note: None.
[1]: https://github.com/cockroachdb/cockroach/blob/12198a51408e7333cd4f96b221e6734239479765/build/teamcity/cockroach/nightlies/roachtest_nightly_gce.sh#L10-L11
Member
Collaborator
Author
Collaborator
Author
|
TFTR! bors r=rickystewart |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Roachtest Stress TeamCity job uses
make(via themkrelease.shscript) for building the required binaries. Recently, thepipeline started hanging while building the binary. Rather than
investigating and fixing the existing
make-based pipeline, convert thejob to using Bazel for building the binaries.
Retain the existing entrypoint to the job, converting it to use the
existing pattern of calling
run_bazelwith the requiredenvironment variables, invoking an
_impl.shscript. The existing logicis moved into the new
_impl.shscript, with some minor additions tosource some additional scripts.
Additionally, the TeamCity job itself was updated to set pass in the
TARGET_CLOUDenvironment variable (set togce), and remove the needto build within a container (instead deferring to Bazel to manage the
build environment). The diff for the TeamCity pipeline is as follows
(for posterity):
Release note: None.