sql: enable streamer for lookup joins#81798
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2022
Merged
Conversation
Member
|
This change is |
We've just fixed an issue with incorrectly using leaf txns for mutations because of the streamer, so I think it is ok to fully enable the streamer. I expect that there might be some fallout, so I'm curious to see the run of nightlies. Release note: None
4f51adc to
d026b52
Compare
michae2
approved these changes
May 25, 2022
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've just fixed an issue with incorrectly using leaf txns for mutations
because of the streamer, so I think it is ok to fully enable the
streamer. I expect that there might be some fallout, so I'm curious to
see the run of nightlies.
Release note: None