util/metric: delete Rate#81777
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2022
Merged
Conversation
Member
|
This change is |
tbg
approved these changes
May 25, 2022
abarganier
approved these changes
May 25, 2022
Contributor
abarganier
left a comment
There was a problem hiding this comment.
My favorite kind of PR 😍
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dhartunian)
This exponentially moving Rate was unused. It also was exporting to Prometheus as a gauge. It seems unlikely that we'll use this in the future; I think we're happy enough with counters and computing rates in the monitoring system. The Rate seems to have come from a time when we liked moving measurements more; since then, we've adapted the Histogram, for example, to include non-windowed state. Release note: None
c94f338 to
8bb2428
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exponentially moving Rate was unused. It also was exporting to
Prometheus as a gauge. It seems unlikely that we'll use this in the
future; I think we're happy enough with counters and computing rates in
the monitoring system. The Rate seems to have come from a time when we
liked moving measurements more; since then, we've adapted the Histogram,
for example, to include non-windowed state.
Release note: None