sql/schemachanger: respect user type for computed columns#81699
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 24, 2022
Merged
sql/schemachanger: respect user type for computed columns#81699craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Before this change, we'd use the inferred type of the expression to determine the type of the column. This is wrong, we must use the type provided by the user. Fortunately, we've never shipped this code. Along the way, this also fixes a bug whereby unsupported vector types could be added as computed columns. Release note: None
Member
|
This change is |
fqazi
approved these changes
May 24, 2022
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Good find!
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, we'd use the inferred type of the expression to determine
the type of the column. This is wrong, we must use the type provided by the
user. Fortunately, we've never shipped this code.
Along the way, this also fixes a bug whereby unsupported vector types could be
added as computed columns.
Release note: None