kvserver: fix raft handling stats when no ready present#81660
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 23, 2022
Merged
kvserver: fix raft handling stats when no ready present#81660craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
We were previously adding `time.Time{}.Sub(timeutil.Now()` to
the metrics which produces bogus results.
Release note: None
Member
|
This change is |
erikgrinaker
approved these changes
May 23, 2022
Member
Author
|
bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously adding
time.Time{}.Sub(timeutil.Now())tothe metrics some of the time which produces bogus results.
Noticed while working on #81516.
Release note: None