kvserver: address assorted comments from previous refactor of TransferLeaseTarget()#81403
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2022
Conversation
Member
|
This change is |
a5ffb0d to
7c47f92
Compare
nvb
approved these changes
May 24, 2022
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15)
pkg/kv/kvserver/allocator/allocatorimpl/allocator.go line 1498 at r1 (raw file):
candidates := make([]roachpb.ReplicaDescriptor, 0, len(existing)) for i := range existing { if !existing[i].IsVoterNewConfig() {
Should we call roachpb.CheckCanReceiveLease directly?
…erLeaseTarget()` This commit addresses miscelleneous review comments from cockroachdb#80834. Release note: None
7c47f92 to
3a28a7f
Compare
aayushshah15
commented
May 25, 2022
Contributor
Author
aayushshah15
left a comment
There was a problem hiding this comment.
TFTR
bors r+
Reviewable status:
pkg/kv/kvserver/allocator/allocatorimpl/allocator.go line 1498 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Should we call
roachpb.CheckCanReceiveLeasedirectly?
Done.
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses miscelleneous review comments from #80834.
Release note: None