outliers: introduce a composite "any" detector#81295
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 16, 2022
matthewtodd:outliers-any
Merged
outliers: introduce a composite "any" detector#81295craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:outliers-any
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:outliers-any
Conversation
Member
|
This change is |
This gives us a place to hang the upcoming histogram-based detector coming in #79451. Release note: None
jocrl
approved these changes
May 16, 2022
Contributor
jocrl
left a comment
There was a problem hiding this comment.
nit: the name isOutlier doesn't seem to imply that it has side effects. Maybe analyzeIsOutlier/assessOutlier? I don't like my suggestions much either, they seem clunky 😛
Aside from that, 
Reviewable status:
complete! 1 of 0 LGTMs obtained
matthewtodd
commented
May 16, 2022
Author
matthewtodd
left a comment
There was a problem hiding this comment.
TFTR, @jocrl, and nice idea to consider that naming -- I agree, will have a think on it.
Reviewable status:
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us a place to hang the upcoming histogram-based detector
coming in #79451.
Release note: None