Skip to content

ttljob: fix a range edge case#81207

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:fix_stuff
May 14, 2022
Merged

ttljob: fix a range edge case#81207
craig[bot] merged 2 commits intocockroachdb:masterfrom
otan-cockroach:fix_stuff

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented May 12, 2022 •
edited
Loading

See individual commits for details.

Refs: #81208

@otan
ttljob: add debugging info
b78f991 
Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented May 12, 2022

This change is Reviewable

@otan otan requested a review from rafiss May 12, 2022 12:37
@otan otan marked this pull request as ready for review May 12, 2022 12:38
@otan otan requested a review from a team May 12, 2022 12:38
@otan otan force-pushed the fix_stuff branch 6 times, most recently from 263163b to bfd1754 Compare May 13, 2022 20:02
@otan
ttljob: fix a range edge case
036f3f5 
Release note (bug fix): Fix a bug in row-level TTL where the last range
key of a table may overlap with a separate table or index, resulting in
a "error decoding X bytes" error message when performing row-level TTL.
rafiss
rafiss approved these changes May 14, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. but there probably are other folks out there who know range encoding better than me, so idk if there's a different way

@otan
Copy link
Copy Markdown
Contributor Author

otan commented May 14, 2022

i looked at how SHOW RANGES FOR TABLE worked and uh yeah this is what i found :D!

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 14, 2022

Build succeeded:

@craig craig bot merged commit 16c484a into cockroachdb:master May 14, 2022
@blathers-crl blathers-crl bot mentioned this pull request May 14, 2022
Merged
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented May 14, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from 036f3f5 to blathers/backport-release-22.1.0-81207: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.0 failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@otan otan mentioned this pull request May 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@otan @cockroach-teamcity @rafiss