storage: remove Engine.SetUpperBound#81194
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom May 16, 2022
Merged
Conversation
`Engine.ClearIterRange` now creates the iterator itself, instead of having it passed in. This ensures the iterator is created with appropriate bounds and options, which becomes even more important with the introduction of range keys. It will also allow removal of `Engine.SetUpperBound` in a subsequent commit. If further flexibility is needed, we can consider passing an `IterOptions` struct with appropriate bounds instead of a key span. Release note: None
This patch removes the `Engine.SetUpperBound` method, as it is no longer in use. Release note: None
Member
|
This change is |
This was referenced May 13, 2022
jbowens
approved these changes
May 16, 2022
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 10 of 12 files at r1, 6 of 7 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aliher1911, @nicktrav, and @sumeerbhola)
Contributor
Author
|
TFTR! bors r=jbowens |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial resubmit of #79291, which was merged into the
mvcc-range-tombstonesbranch.storage: make
Engine.ClearIterRangeconstruct iterator internallyEngine.ClearIterRangenow creates the iterator itself, instead ofhaving it passed in. This ensures the iterator is created with
appropriate bounds and options, which becomes even more important with
the introduction of range keys. It will also allow removal of
Engine.SetUpperBoundin a subsequent commit.If further flexibility is needed, we can consider passing an
IterOptionsstruct with appropriate bounds instead of a key span.Release note: None
storage: remove
Engine.SetUpperBoundThis patch removes the
Engine.SetUpperBoundmethod, as it is no longerin use.
Release note: None