Skip to content

backupccl: break dependency to testcluster#80773

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:220429.backupccl-testcluster
Apr 29, 2022
Merged

backupccl: break dependency to testcluster#80773
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:220429.backupccl-testcluster

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

Noticed we were building testing library packages when building CRDB
binaries.

$ bazel query "somepath(//pkg/cmd/cockroach-short, //pkg/testutils/testcluster)"
//pkg/cmd/cockroach-short:cockroach-short
//pkg/cmd/cockroach-short:cockroach-short_lib
//pkg/ccl:ccl
//pkg/ccl/backupccl:backupccl
//pkg/testutils/testcluster:testcluster

Release note: None

@irfansharif irfansharif requested review from a team and msbutler and removed request for a team April 29, 2022 06:23
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@irfansharif irfansharif force-pushed the 220429.backupccl-testcluster branch from 3a23383 to 1494798 Compare April 29, 2022 06:23
Noticed we were building testing library packages when building CRDB
binaries.

    $ bazel query "somepath(//pkg/cmd/cockroach-short, //pkg/testutils/testcluster)"
    //pkg/cmd/cockroach-short:cockroach-short
    //pkg/cmd/cockroach-short:cockroach-short_lib
    //pkg/ccl:ccl
    //pkg/ccl/backupccl:backupccl
    //pkg/testutils/testcluster:testcluster

Release note: None
@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 29, 2022

Build succeeded:

@craig craig bot merged commit 0777ef7 into cockroachdb:master Apr 29, 2022
@irfansharif irfansharif deleted the 220429.backupccl-testcluster branch April 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants