security/password: trim down dependencies further#80760
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 29, 2022
Merged
security/password: trim down dependencies further#80760craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ZhouXing19
reviewed
Apr 28, 2022
Collaborator
ZhouXing19
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @knz and @ZhouXing19)
pkg/security/password.go line 220 at r1 (raw file):
return nil, err } return alloc.Release, err
nit: should return alloc.Release, nil
Collaborator
|
Previously, ZhouXing19 (Jane Xing) wrote…
Done. |
This removes many more indirect dependencies by not requiring quotapool and util/log. Release note: None
Contributor
|
In #80687 I pull |
Collaborator
Yes I agree, and seems to me that the two PRs do not conflict. |
Collaborator
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes many more indirect dependencies by not requiring
quotapool and util/log.
Release note: None