settings: Prevent new sql.defaults cluster settings from being added#80575
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 3, 2022
Merged
settings: Prevent new sql.defaults cluster settings from being added#80575craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
9d1f096 to
e13897e
Compare
otan
approved these changes
Apr 28, 2022
pkg/settings/registry.go
Outdated
| if strings.Contains(key, "sql.defaults") { | ||
| if _, ok := sqlDefaultSettings[key]; !ok { | ||
| panic(fmt.Sprintf( | ||
| "new sql.defaults cluster settings: %s is not needed now that `ALTER ROLE..SET` syntax is supported", key)) |
Contributor
There was a problem hiding this comment.
nit: new sql.defaults cluster setting detected: %s is not needed now that ALTER ROLE ... SET syntax is supported
In order to encourage the use of `ALTER ROLE` this commit adds a panic that prevents new sql.default cluster settings from being added. Release note: None
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #80324
In order to encourage the use of
ALTER ROLEthis commit addsa panic that prevents new sql.default cluster settings from being
added.
Release note: None