storage: fix accounting for orig LiveBytes in updateStatsOnResolve#80443
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 23, 2022
Merged
storage: fix accounting for orig LiveBytes in updateStatsOnResolve#80443craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes a latent bug where `updateStatsOnResolve`'s attempt to discount the effect of the previous intent's key and value size on the stats' `LiveBytes` field used the new value's size instead of the old value's size. I've tracked this back to 92cad17. This is currently harmless because intent value sizes never change during intent resolution. However, this may not be the case in the future. For instance, this will not be the case if we store local timestamps in an `MVCCValue` wrapper object, as is being explored in cockroachdb#77342.
Member
|
This change is |
tbg
approved these changes
Apr 23, 2022
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a latent bug where
updateStatsOnResolve's attempt todiscount the effect of the previous intent's key and value size on the
stats'
LiveBytesfield used the new value's size instead of the oldvalue's size. I've tracked this back to 92cad17.
This is currently harmless because intent value sizes never change
during intent resolution. However, this may not be the case in the
future. For instance, this will not be the case if we store local
timestamps in an
MVCCValuewrapper object, as is being exploredin #77342.