ci: ensure nightlies have all the env vars they need to post issues#80284
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 20, 2022
Merged
ci: ensure nightlies have all the env vars they need to post issues#80284craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Without these environment variables, these nightlies won't be able to run `process_test_json` or post GitHub issues. Closes cockroachdb#79403. Release note: None
fb15776 to
f542f65
Compare
cucaroach
approved these changes
Apr 20, 2022
Contributor
cucaroach
left a comment
There was a problem hiding this comment.
Seems like a lot of unfortunate repetition but otherwise :ltgm:
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rail)
Collaborator
Author
I'll look at the repetition as a follow-up. bors r=cucaroach,rail |
rail
approved these changes
Apr 20, 2022
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these environment variables, these nightlies won't be able to
run
process_test_jsonor post GitHub issues.Closes #79403.
Release note: None