sql: add cluster setting to tune sql stats cleanup job behavior#80191
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 20, 2022
Merged
sql: add cluster setting to tune sql stats cleanup job behavior#80191craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Related to cockroachdb#79548 Previously, SQL Stats cleanup job was configured to break the delete operation into many small transactions. Each transaction could only delete up to 128 rows. This number was hardcoded and has shown to be problematic when there are large number of MVCC garbages. This commit changes this value into a new non-public cluster settings `sql.stats.cleanup.rows_to_delete_per_txn` with default value being 1024. The higher default value is bumped higher in order to amortize the cost of scanning over large amount of MVCC garbage. Release note: None
Member
|
This change is |
maryliag
approved these changes
Apr 19, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This was referenced Apr 20, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #79548
Previously, SQL Stats cleanup job was configured to break the
delete operation into many small transactions. Each transaction could
only delete up to 128 rows. This number was hardcoded and has shown to
be problematic when there are large number of MVCC garbages.
This commit changes this value into a new non-public cluster
settings
sql.stats.cleanup.rows_to_delete_per_txnwith default valuebeing 1024. The higher default value is bumped higher in order to
amortize the cost of scanning over large amount of MVCC garbage.
Release note: None