Skip to content

security: hide a cluster setting.#79954

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20220414-prehashed
Apr 14, 2022
Merged

security: hide a cluster setting.#79954
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20220414-prehashed

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Apr 14, 2022

As discussed with Rafi, we don't really have good use cases for the
cluster setting
server.user_login.store_client_pre_hashed_passwords.enabled. It's
really only available for troubleshooting our implementation of hash
detection.

Making it visible to end-users is likely to invite more support
trouble than it's worth.

Release note: None

As discussed with Rafi, we don't really have good use cases for the
cluster setting
`server.user_login.store_client_pre_hashed_passwords.enabled`. It's
really only available for troubleshooting our implementation of hash
detection.

Making it visible to end-users is likely to invite more support
trouble than it's worth.

Release note: None
@knz knz requested a review from rafiss April 14, 2022 16:22
@knz knz requested a review from a team as a code owner April 14, 2022 16:22
@knz knz requested a review from a team April 14, 2022 16:22
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Apr 14, 2022

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 14, 2022

Build succeeded:

@craig craig bot merged commit 266cdf5 into cockroachdb:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants