logictest: fix potential race with async statements#79925
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 14, 2022
Merged
logictest: fix potential race with async statements#79925craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
While statements in logictests with the `async` option start a new goroutine to execute the statement via `db.Exec(..)`, there was a potential race because the database handle `t.db` was shared without a mutex, and could be changed by other operations such as `user <newuser>`. This change fixes the issue by capturing a reference to the database handle prior to starting the goroutine, thus eliminating the porential race. Release note: None
Member
|
This change is |
yuzefovich
approved these changes
Apr 14, 2022
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
yuzefovich
reviewed
Apr 14, 2022
Member
yuzefovich
left a comment
There was a problem hiding this comment.
We also want to backport this to 22.1, right?
Reviewable status:
AlexTalks
commented
Apr 14, 2022
Contributor
Author
AlexTalks
left a comment
There was a problem hiding this comment.
Yes - I believe we can still backport test-only changes like this without issue? I believe the backport for #77876 may need to wait some time (though I hope to merge to master sooner).
Reviewable status:
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While statements in logictests with the
asyncoption start a newgoroutine to execute the statement via
db.Exec(..), there was apotential race because the database handle
t.dbwas shared without amutex, and could be changed by other operations such as
user <newuser>.This change fixes the issue by capturing a reference to the
database handle prior to starting the goroutine, thus eliminating the
porential race.
Release note: None