roachtest: upgrade activerecord test#79776
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 12, 2022
Merged
Conversation
Also updates flaky test list. Release note: None
Member
|
This change is |
otan
approved these changes
Apr 11, 2022
| var activeRecordBlockList20_2 = blocklist{} | ||
|
|
||
| var activeRecordIgnoreList22_1 = blocklist{ | ||
| "CockroachDB::PostgresqlIntervalTest#test_interval_type": "flaky", |
Collaborator
Author
There was a problem hiding this comment.
i think the way we override intervalstyle is racy due to this comment:
https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c37e78aeb017933a1a7794c0d00ae7a9562692c7/lib/active_record/connection_adapters/cockroachdb_adapter.rb#L268-L271
hmmmm maybe we should move it back into configure_connection, but just make it handle and ignore an error if the SET fails?
Collaborator
Author
|
bors r=otan |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #77914
Also updates flaky test list.
Release note: None