Skip to content

kvserver: track incoming raft message queue byte size#79378

Closed
tbg wants to merge 13 commits intocockroachdb:masterfrom
tbg:raft-queue-size
Closed

kvserver: track incoming raft message queue byte size#79378
tbg wants to merge 13 commits intocockroachdb:masterfrom
tbg:raft-queue-size

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Apr 4, 2022

Release note: None

Jira issue: CRDB-14768

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@tbg tbg force-pushed the raft-queue-size branch 2 times, most recently from e7ad0f4 to 0cc8371 Compare April 5, 2022 09:32
aayushshah15 and others added 6 commits April 6, 2022 15:27
This commit adds a safeguard inside
`Replica.maybeLeaveAtomicChangeReplicasAndRemoveLearners()` to avoid removing
learner replicas _when we know_ that that learner replica is in the process of
receiving its initial snapshot (as indicated by an in-memory lock on log
truncations that we place while the snapshot is in-flight).

This change should considerably reduce the instances where `AdminRelocateRange`
calls are interrupted by the mergeQueue or the replicateQueue (and vice versa).

Fixes cockroachdb#57129
Relates to cockroachdb#79118

Release note: none
@tbg tbg force-pushed the raft-queue-size branch from 50327e0 to 1bff819 Compare April 6, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants