sql: fix join reader errors hitting memory limit#79330
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 5, 2022
Merged
sql: fix join reader errors hitting memory limit#79330craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Restore non-streamer memory limit lower bound to 8MiB for join reader. Streamer can handle a lower limit so we lowered it to 100KiB but that is too low for some cases (like sqllitetests). Also tpchvec roachtest has 650KiB lower limit for workmem which is too low for query 20 so restoring the 8MiB lower bound will fix that as well. Fixes: cockroachdb#78247 Fixes: cockroachdb#78341 Fixes: cockroachdb#77929 Release note: None
Member
|
This change is |
yuzefovich
approved these changes
Apr 4, 2022
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore non-streamer memory limit lower bound to 8MiB for join reader.
Streamer can handle a lower limit so we lowered it to 100KiB but that is
too low for some cases (like sqllitetests). Also tpchvec roachtest
has 650KiB lower limit for workmem which is too low for query 20 so
restoring the 8MiB lower bound will fix that as well.
Fixes: #78247
Fixes: #78341
Fixes: #77929
Release note: None
Jira issue: CRDB-14708