release-22.1: sql: disallow tenants from setting zone configs by default#79160
Merged
arulajmani merged 1 commit intorelease-22.1from Apr 4, 2022
Merged
Conversation
feec34f to
2de953e
Compare
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
|
This change is |
nvb
approved these changes
Mar 31, 2022
Previously, `sql.zone_configs.allow_for_secondary_tenant.enabled` was a regular old cluster setting that tenants could control. Now that we have a notion of tenant read-only setting, this feels like a great candidate for it. In addition to making this switch, this patch also changes this setting's default value to be false. See the linked issue for the motivation around why. The change to switch this setting to be tenant read-only necessitates changes in how we run logic tests. This is because logic tests that run as secondary tenants can no longer change this cluster setting in the test file. We introduce a new `tenant-cluster-setting-override-opt` logic test directive with an option for `allow-zone-configs-for-secondary-tenants` to get this working. When configured, the host alters this cluster setting during test setup. This can later be extended for other read-only settings in the future. References #77344 Release note (sql change): Changes the default value of `sql.zone_configs.allow_for_secondary_tenant.enabled` to be false. Moreover, this setting is no longer settable by secondary tenants. Instead, it's now a tenant read-only cluster setting.
2de953e to
a7e3e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #79097 on behalf of @arulajmani.
/cc @cockroachdb/release
Previously,
sql.zone_configs.allow_for_secondary_tenant.enabledwas aregular old cluster setting that tenants could control. Now that we have
a notion of tenant read-only setting, this feels like a great candidate
for it. In addition to making this switch, this patch also changes this
setting's default value to be false. See the linked issue for the
motivation around why.
The change to switch this setting to be tenant read-only necessitates
changes in how we run logic tests. This is because logic tests that
run as secondary tenants can no longer change this cluster setting
in the test file. We introduce a new
tenant-cluster-setting-override-optlogic test directive with anoption for
allow-zone-configs-for-secondary-tenantsto get thisworking. When configured, the host alters this cluster setting
during test setup. This can later be extended for other read-only
settings in the future.
References #77344
Release note (sql change): Changes the default value of
sql.zone_configs.allow_for_secondary_tenant.enabledto be false.Moreover, this setting is no longer settable by secondary tenants.
Instead, it's now a tenant read-only cluster setting.
Release justification: "low risk change to new functionality"