Skip to content

ui: update Hot ranges page styles#79133

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
koorosh:ui-hot-ranges-nits
Apr 5, 2022
Merged

ui: update Hot ranges page styles#79133
craig[bot] merged 1 commit intocockroachdb:masterfrom
koorosh:ui-hot-ranges-nits

Conversation

@koorosh
Copy link
Copy Markdown
Contributor

@koorosh koorosh commented Mar 31, 2022

Current change introduces several minor UI changes
on Hot Ranges page:

  • changed page description, not it isn't rendered as
    inline alert;
  • Data formatting is changed to use UTC;
  • Changed heading style to H3 to follow the same style
    as other pages;
  • QPS values are rounded to 2 decimals;

Release note (ui change): minor styling changes on
Hot Ranges page to follow the same style as other pages.

Resolves: #78517

Screens:
Screen Shot 2022-03-31 at 17 35 08

Jira issue: CRDB-14827

@koorosh koorosh requested review from Santamaura and zachlite March 31, 2022 14:37
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@koorosh koorosh force-pushed the ui-hot-ranges-nits branch 2 times, most recently from 17adffb to 9b9d660 Compare April 1, 2022 10:46
Copy link
Copy Markdown
Contributor

@Santamaura Santamaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @koorosh and @zachlite)


pkg/ui/workspaces/db-console/src/views/hotRanges/index.tsx, line 68 at r1 (raw file):

        (queries per second). <br />
        Use this information to
        <Anchor href="" target="_blank">

Are we removing the link here on purpose?

Current change introduces several minor UI changes
on Hot Ranges page:
- changed page description, not it isn't rendered as
inline alert;
- Data formatting is changed to use UTC;
- Changed heading style to H3 to follow the same style
as other pages;
- QPS values are rounded to 2 decimals;

Release note (ui change): minor styling changes on
Hot Ranges page to follow the same style as other pages.
@koorosh koorosh force-pushed the ui-hot-ranges-nits branch from 9b9d660 to 488d64b Compare April 4, 2022 16:12
Copy link
Copy Markdown
Contributor Author

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @Santamaura and @zachlite)


pkg/ui/workspaces/db-console/src/views/hotRanges/index.tsx, line 68 at r1 (raw file):

Previously, Santamaura (Alex Santamaura) wrote…

Are we removing the link here on purpose?

oh, that's my fault, it should be brought back. Thanks!

@koorosh koorosh requested a review from Santamaura April 4, 2022 19:10
Copy link
Copy Markdown
Contributor

@Santamaura Santamaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @koorosh, @Santamaura, and @zachlite)

a discussion (no related file):
:lgtm:


@koorosh
Copy link
Copy Markdown
Contributor Author

koorosh commented Apr 5, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 5, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hot ranges page v1 clean-up for 22.1

3 participants