kvserver: make the StoreRebalancer interval a cluster setting#78962
Conversation
|
This change is |
nvb
left a comment
There was a problem hiding this comment.
Thanks. Do you think we should backport this to 22.1 and other release branches?
pkg/kv/kvserver/store_rebalancer.go
Outdated
| // Setting this interval to a very low duration is generally going to be a | ||
| // bad idea without any real benefit, so let's disallow that. | ||
| const min = 10 * time.Second | ||
| if d <= min { |
There was a problem hiding this comment.
nit: consider making the allowable range inclusive of 10 seconds so that it's easier to set this setting to its minimum value.
Release note (ops change): the `kv.allocator.load_based_rebalancing_interval` cluster setting now lets operators the interval at which each store in the cluster will check for load-based lease or replica rebalancing opportunities.
7228a17 to
119f031
Compare
aayushshah15
left a comment
There was a problem hiding this comment.
Yes, I think it's good to backport this.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvserver/store_rebalancer.go, line 114 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
nit: consider making the allowable range inclusive of 10 seconds so that it's easier to set this setting to its minimum value.
Done.
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 119f031 to blathers/backport-release-21.1-78962: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1.x failed. See errors above. error creating merge commit from 119f031 to blathers/backport-release-21.2-78962: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. error creating merge commit from 119f031 to blathers/backport-release-22.1-78962: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Release note (ops change): the
kv.allocator.load_based_rebalancing_intervalcluster setting now lets operators choose the interval at which each store in the
cluster will check for load-based lease or replica rebalancing opportunities.