sql: add logging for grant_role#78653
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 29, 2022
Merged
Conversation
Member
|
This change is |
ajwerner
approved these changes
Mar 28, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Collaborator
|
This would have made the investigation in https://github.com/cockroachlabs/support/issues/1463 easier so I'm also in favor of a backport to 22.1. It's a new proto, so I don't know if 21.2 is eligible. |
d25a4d7 to
4a927db
Compare
GRANT ROLE now logs to the logpb.Channel_USER_ADMIN channel. Example: GRANT role1, role2 TO role3, role4 logs "GranteeRoles":["‹role1›","‹role2›"],"Members":["‹role3›","‹ role4›"] Release note: None
4a927db to
909368d
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRANT ROLE now logs to the logpb.Channel_USER_ADMIN channel.
Example: GRANT role1, role2 TO role3, role4 logs
"RoleNames":"‹role1›",‹role2›","Members":"‹role3›",‹ role4›"
Release note: None
Fixes #78245