backupccl: add deprecation warning for SHOW BACKUP without subdir#78626
backupccl: add deprecation warning for SHOW BACKUP without subdir#78626craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
benbardin
left a comment
There was a problem hiding this comment.
Can/do we have some documentation on the deprecation of old-style backups in general? I wonder if it would be clearer to users if the 3-4 places they'd interact with this reference the same github issue explicitly. I don't know that it's intrinsically clear that "BACKUP INTO" means "collection" syntax and "BACKUP TO" means...well, whatever it means. Thoughts?
Informs: cockroachdb#78153 Release note (sql change): The `SHOW BACKUP` cmd without the `IN` keyword to specify a subdirectory is deprecated and will be removed from a future release. Users are recommended to only create collection based backups and view them with `SHOW BACKUP FROM <backup> IN <collection>`
fa5603a to
5201176
Compare
|
@benbardin I think your question will be easier to answer once @kathancox updates the 22.1 docs. Given that the BACKUP and RESTORE warnings have already been backported, I think we should backport this PR ASAP. Then, we can consider updating each warning link once the docs are up to date? |
Yeah, makes sense to me! LGTM. Thanks! |
|
TFTRS!!! bors r = adityamaru, benbardin |
|
bors r=adityamaru, benbardin |
|
Build succeeded: |
Informs: #78153
Release note (sql change): The
SHOW BACKUPcmd without theINkeyword tospecify a subdirectory is deprecated and will be removed from a future release.
Users are recommended to only create collection based backups and view them
with
SHOW BACKUP FROM <backup> IN <collection>