Skip to content

Week -1: follow-up emails#78595

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
celiala:follow-up-emails
Apr 11, 2022
Merged

Week -1: follow-up emails#78595
craig[bot] merged 1 commit intocockroachdb:masterfrom
celiala:follow-up-emails

Conversation

@celiala
Copy link
Copy Markdown
Collaborator

@celiala celiala commented Mar 28, 2022 •
edited
Loading

This PR adds follow-up emails for:

  • the day before PrepDate (to be sent if only there are still blockers)
  • the day of PrepDate (to be sent if only there are still blockers)
  • the day after PrepDate (to be sent if only there are still blockers)

The post-blockers command should be used for all emails before and up to PrepDate:

# where `DAYS_BEFORE_PREP` is one of: many-days | day-before | day-of

SMTP_PASSWORD=$MY_SMTP_PWD SMTP_USER=$MY_SMTP_USER GITHUB_TOKEN=$MY_GITHUB_TOKEN \
$(bazel info bazel-bin)/pkg/cmd/release/release_/release post-blockers \
  --release-series 21.1 \
  --smtp-user $MY_SMTP_USER --smtp-host smtp.gmail.com --smtp-port 587 \
  --to $MY_TO_EMAIL \
  --template-dir ./pkg/cmd/release/templates \
  --prep-date "Apr 1, 2022" --publish-date "May 1, 2022" \
  --days-before-prep-date $DAYS_BEFORE_PREP

The cancel-release-date should be used for the day after PrepDate email:

SMTP_PASSWORD=$MY_SMTP_PWD SMTP_USER=$MY_SMTP_USER GITHUB_TOKEN=$MY_GITHUB_TOKEN \
$(bazel info bazel-bin)/pkg/cmd/release/release_/release cancel-release-date \
  --release-series 21.1 \
  --smtp-user $MY_SMTP_USER --smtp-host smtp.gmail.com --smtp-port 587 \
  --to $MY_TO_EMAIL \
  --template-dir ./pkg/cmd/release/templates \
  --publish-date "May 1, 2022" --next-publish-date "Jun 1, 2022"

TeamCity changes

This will be paired with the following TeamCity jobs:

image

Manual tests

Test 1: post-blockers --days-before-prep-date many-days

Test 2: post-blockers --days-before-prep-date day-before

Test 3: post-blockers --days-before-prep-date day-of

Test 4: cancel-release-date

@celiala celiala requested a review from a team as a code owner March 28, 2022 07:53
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Mar 28, 2022

This change is Reviewable

@celiala celiala force-pushed the follow-up-emails branch 2 times, most recently from a8043c3 to d8fbaca Compare March 28, 2022 08:36
@celiala celiala requested a review from rail March 28, 2022 09:01
@celiala
Copy link
Copy Markdown
Collaborator Author

celiala commented Mar 28, 2022

Hi @rail - I thought I could get these emails up in time for us to run today's "Monday emails" step, but the new parameters don't seem to be wired up correctly 🤔 . See failed attempts:

https://teamcity.cockroachdb.com/buildConfiguration/Internal_Cockroach_Release_Process_SendReleaseBlockers_78595?branch=78595&mode=builds#all-projects

Maybe we can chat about this further in today's weekly release meeting.

@celiala
Copy link
Copy Markdown
Collaborator Author

celiala commented Apr 11, 2022

Hi @rail - I just squashed -- this is RFAL whenever you have a moment, thank you!

rail
rail approved these changes Apr 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 42 of 42 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @celiala)

@celiala
release: add follow-up emails for Week -1 automation
e6ddbf7 
This PR adds follow-up emails for:

the day before PrepDate (to be sent if only there are still blockers)
the day of PrepDate (to be sent if only there are still blockers)
the day after PrepDate (to be sent if only there are still blockers)

Release note (<category, see below>): <what> <show> <why>
@celiala
Copy link
Copy Markdown
Collaborator Author

celiala commented Apr 11, 2022

TFTR!

bors r=rail

@craig craig bot merged commit 6de7a18 into cockroachdb:master Apr 11, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 11, 2022

Build succeeded:

@cockroach-teamcity cockroach-teamcity mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rail rail rail approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@celiala @cockroach-teamcity @rail