[dnm] sql,kv,storage: add AS OF SYSTEM TIME ALL#78540
Draft
jordanlewis wants to merge 3 commits intocockroachdb:masterfrom
Draft
[dnm] sql,kv,storage: add AS OF SYSTEM TIME ALL#78540jordanlewis wants to merge 3 commits intocockroachdb:masterfrom
jordanlewis wants to merge 3 commits intocockroachdb:masterfrom
Conversation
Previously, the argument list to row.Fetcher.Init was too long. Now, it takes an arg struct to reduce this pain. This is a pure refactor. Release note: None
Previously, this function had way too many arguments. Replace them with an argument struct. This is a pure refactor. Release note: None
Member
This commit adds support for an "all versions scan" style from SQL down to KV. It permits using the `AS OF SYSTEM TIME ALL` modifier to instruct the system to return all MVCC versions of the scanned data, rather than just the most recent under the read timestamp. Release note: add AS OF SYSTEM TIME ALL, a modifier that gives all MVCC versions on disk for the scanned data.
627fca3 to
2c66296
Compare
Member
Author
|
Here's a simple demo: |
Collaborator
|
This is cool! |
|
@jordanlewis what is the status of this enhancement? there a few compelling use cases for this feature. |
Member
Author
|
The status is that it's abandoned. I don't have bandwidth to push on it
anymore. If someone is interested in picking it up be my guest! It may
(probably?) need to be rewritten as the patch is quite old.
…On Fri, Feb 16, 2024, 16:03 Drew ***@***.***> wrote:
@jordanlewis <https://github.com/jordanlewis> what is the status of this
enhancement? there a few compelling use cases for this feature.
—
Reply to this email directly, view it on GitHub
<#78540 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKWLJNWT6UES3DRWN7BHLYT7QT3AVCNFSM5RVSRO4KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJUHE2DKOJVGIYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First two commits are #78539.
Closes #19749 (though this is still a draft, up for discussion)
This is still a work in progress. Here is a checklist of things that we'll need to do before we can consider merging: