ccl/sqlproxyccl: rename tenant.Resolver to tenant.DirectoryCache #78276
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 23, 2022
Merged
ccl/sqlproxyccl: rename tenant.Resolver to tenant.DirectoryCache #78276craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Previously, the TenantResolver interface lived in the base sqlproxyccl package, and there was no way to enforce that the tenant.Directory struct implements this interface since that would result in a cyclic dependency. This commit moves the TenantResolver interface into the tenant package, and enforced that the tenant.Directory struct implements that. This would then allow us to rename the tenant.Directory struct to tenant.directoryCache, and the tenant.Resolver interface to tenant.DirectoryCache. Release note: None
This commit renames the tenant.Resolver interface to tenant.DirectoryCache. The existing Directory struct was also renamed to directoryCache to prevent confusions since there were previously two definitions of a "directory": one pointing to the cache of entries, whereas another referring to the actual directory server. Release note: None
This was referenced Mar 22, 2022
Member
|
This change is |
andy-kimball
approved these changes
Mar 22, 2022
Contributor
andy-kimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r=JeffSwenson,andy-kimball |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
Contributor
Author
|
blathers backport 22.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #76000.
ccl/sqlproxyccl: move the TenantResolver interface to the tenant package
Previously, the TenantResolver interface lived in the base sqlproxyccl package,
and there was no way to enforce that the tenant.Directory struct implements
this interface since that would result in a cyclic dependency. This commit
moves the TenantResolver interface into the tenant package, and enforced that
the tenant.Directory struct implements that.
This would then allow us to rename the tenant.Directory struct to
tenant.directoryCache, and the tenant.Resolver interface to
tenant.DirectoryCache.
Release note: None
ccl/sqlproxyccl: rename tenant.Resolver to tenant.DirectoryCache
This commit renames the tenant.Resolver interface to tenant.DirectoryCache.
The existing Directory struct was also renamed to directoryCache to prevent
confusions since there were previously two definitions of a "directory": one
pointing to the cache of entries, whereas another referring to the actual
directory server.
Release note: None