distsql: simple projection in experimental distsql planner panics#78213
distsql: simple projection in experimental distsql planner panics#78213craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
b03b8f3 to
2070408
Compare
Previously, selecting a given column from a table more than once could cause an `index out of range` panic when experimental_distsql_planning is set to always, for example: ``` CREATE TABLE kv (k INT PRIMARY KEY, v INT); INSERT INTO kv VALUES (1, 1), (2, 1), (3, 2); SET experimental_distsql_planning = always; SELECT v, k, k, v FROM kv; ``` This commit fixes the issue, which is due to incorrect mapping of selected columns to source column ordinals in `ConstructSimpleProject`. Release note: none
2070408 to
92e940c
Compare
yuzefovich
left a comment
There was a problem hiding this comment.
Nice find!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
cucaroach
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
|
Is there an open issue for this? Should this be backported? |
|
No need to backport this since it's encountered only when an experimental setting is turned on. |
msirek
left a comment
There was a problem hiding this comment.
There's no github issue, I just found this while testing another PR.
Reviewable status:
msirek
left a comment
There was a problem hiding this comment.
TFTRs!
bors r+
Reviewable status:
|
Build failed (retrying...): |
|
Build succeeded: |
Previously, selecting a given column from a table more than once could
cause an
index out of rangepanic when experimental_distsql_planningis set to always, for example:
This commit fixes the issue, which is due to incorrect mapping of
selected columns to source column ordinals in
ConstructSimpleProject.Release note: none