ui: remove unnecessary uses of lodash in database pages#78203
ui: remove unnecessary uses of lodash in database pages#78203craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Closes cockroachdb#68820 This commit removes the ue of functions from the lodash function where regular JS can be used. Release note: None
|
This change is |
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
Azhng
left a comment
There was a problem hiding this comment.
Should we purge the lodash from our package.json as well ?
Reviewable status:
|
Unfortunately we're still using it in other places. Most of the use cases are from years ago and can be replaced with simple JS (e.g. |
|
Agreed with Xin Hao, that there are still some places where lodash is useful. Lodash also exports the functions individually, so if we can define a specific set that we want to use we can just import those. I think it's a question of what our goals and priorities are. I also think this might also involve a bigger picture of frontend decisions. For instance, |
|
TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
Closes #68820
This commit removes the ue of functions from the lodash function
where regular JS can be used.
Release note: None