ui: improve UI for statuses on the jobs page#78186
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 22, 2022
Merged
ui: improve UI for statuses on the jobs page#78186craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Addresses cockroachdb#71963 Previously the `cancel-requested`, `pause-requested`, and `revert-failed` had blue badges. Now, `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge. Release note (ui): Improved colors for status badges on the Jobs page. Three status on the Jobs page, `cancel-requested`, `pause-requested`, and `revert-failed`, previously had blue status badge colors that were uninformative of their meaning. This commit modifies the badge colors to reflect their meaning. Now `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge.
Member
|
This change is |
xinhaoz
approved these changes
Mar 21, 2022
Contributor
xinhaoz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jocrl)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Contributor
|
Is this expected to get a 22.1 backport? |
Contributor
Author
|
blathers backport 22.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #71963
Previously the
cancel-requested,pause-requested, andrevert-failedhadblue badges.
Now,
cancel-requestedandpause-requestedhave gray badges andrevert-failedhas a red badge.Release note (ui): Improved colors for status badges on the Jobs page. Three
status on the Jobs page,
cancel-requested,pause-requested, andrevert-failed, previously had blue status badge colors that wereuninformative of their meaning. This commit modifies the badge colors to
reflect their meaning. Now
cancel-requestedandpause-requestedhave graybadges and
revert-failedhas a red badge.