rangefeedcache: use unbounded buffers during initial scans#78148
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 21, 2022
Merged
rangefeedcache: use unbounded buffers during initial scans#78148craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#77687. We previously used a bounded buffer size for the rangefeed cache's initial scan. If the size of the table being scanned is larger than the configured limit, this is unrecoverable. A subsequent retry would run into the same limit. This behavior can have severe negative effects for the span configs infrastructure -- if `system.span_configurations` has a few too many rows, the kvsubscriber instantiated per-store will never be able to read from it. This PR uses an unbounded buffer during the initial scan, and bounds the buffer once we're in the incremental stage. Release justification: low risk, high benefit Release note: None
Member
|
This change is |
arulajmani
approved these changes
Mar 21, 2022
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)
Contributor
Author
|
CI failure was fixed by #78088. bors r+ |
nvb
approved these changes
Mar 21, 2022
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77687. We previously used a bounded buffer size for the rangefeed
cache's initial scan. If the size of the table being scanned is larger
than the configured limit, this is unrecoverable. A subsequent retry
would run into the same limit. This behavior can have severe negative
effects for the span configs infrastructure -- if
system.span_configurationshas a few too many rows, the kvsubscriberinstantiated per-store will never be able to read from it.
This PR uses an unbounded buffer during the initial scan, and bounds the
buffer once we're in the incremental stage.
Release justification: low risk, high benefit
Release note: None