kvserver: include MVCC range keys in replica consistency checks#78104
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 29, 2022
Merged
Conversation
Member
|
This change is |
0d84445 to
5e914fd
Compare
b050b4a to
bb5aa54
Compare
5e914fd to
fcd6a38
Compare
bb5aa54 to
ba8eb78
Compare
aliher1911
approved these changes
Mar 31, 2022
Contributor
aliher1911
left a comment
There was a problem hiding this comment.
Nice use of echotest.Require made tests more readable.
ba8eb78 to
34e6ab0
Compare
fcd6a38 to
e9e5ee7
Compare
34e6ab0 to
4798ae2
Compare
nicktrav
reviewed
Apr 5, 2022
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r16, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @aliher1911 and @tbg)
2097ac5 to
3ad25e4
Compare
e9e5ee7 to
52e77e2
Compare
3ad25e4 to
6a1756c
Compare
52e77e2 to
cbb90f1
Compare
6a1756c to
3bd8605
Compare
603be75 to
03447f1
Compare
3bd8605 to
2c06ce4
Compare
2c06ce4 to
cb77b2e
Compare
83a3d6b to
8dbd47a
Compare
cb77b2e to
49aacac
Compare
8dbd47a to
220b12b
Compare
49aacac to
e5bd560
Compare
a5c681e to
b61f80d
Compare
b61f80d to
6401aab
Compare
6401aab to
877af3c
Compare
877af3c to
9c4fdf8
Compare
Contributor
Author
|
Allright, this one's ready for a final review @aliher1911. It's been 3 months since your last review, so I'll let you have another look, but shouldn't be any major changes. |
This patch adds handling of MVCC range keys in replica consistency checks. These are iterated over as part of `MVCCStats` calculations and hashed similarly to point keys. Range keys will only exist after the version gate `ExperimentalMVCCRangeTombstones` has been enabled, so a separate version gate is not necessary. Release note: None
9c4fdf8 to
ee57d72
Compare
aliher1911
reviewed
Jun 28, 2022
Contributor
aliher1911
left a comment
There was a problem hiding this comment.
Want to clarify thing about tombstone value in the comment below before giving a go.
Contributor
Author
Forget to submit the comment? |
aliher1911
reviewed
Jun 29, 2022
Contributor
Author
|
TFTR! CI failures are unrelated. bors r=aliher1911 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds handling of MVCC range keys in replica consistency
checks. These are iterated over as part of
MVCCStatscalculations andhashed similarly to point keys.
Range keys will only exist after the version gate
ExperimentalMVCCRangeTombstoneshas been enabled, so a separateversion gate is not necessary.
Release note: None