dev: --rewrite should imply --ignore-cache#77784
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 15, 2022
Merged
dev: --rewrite should imply --ignore-cache#77784craig[bot] merged 1 commit intocockroachdb:masterfrom
--rewrite should imply --ignore-cache#77784craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
irfansharif
approved these changes
Mar 14, 2022
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
Applies to dev testlogic as well. Do we need to update testdata files?
If you meant to rewrite again but didn't update any source files, Bazel can reuse the cached results which is confusing. Release justification: Non-production code changes Release note: None
76d01e9 to
090aee9
Compare
Collaborator
Author
Fixed both of these. |
Collaborator
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you meant to rewrite again but didn't update any source files, Bazel
can reuse the cached results which is confusing.
Release justification: Non-production code changes
Release note: None