opt: fix upsert fast path for hash-sharded primary indexes#77775
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 15, 2022
Merged
opt: fix upsert fast path for hash-sharded primary indexes#77775craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
In cockroachdb#76358, a change was made to consider both partitioning and hash-shard columns as implicit, which was required for finding arbiters for UPSERT statements in tables that have partitioned, hash-sharded primary indexes. A side-effect of this change is that it prevents the planning of the fast-path of UPSERTs into tables with hash-sharded primary indexes. This commit fixes this regression. Release justification: This fixes a performance regression for hash-sharded indexes, which are being released as non-experimental in the upcoming release. There is no release note because this regression is not present in any releases. Release note: None
Member
|
This change is |
chengxiong-ruan
approved these changes
Mar 14, 2022
Contributor
chengxiong-ruan
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
rytaft
approved these changes
Mar 14, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:
Contributor
Author
|
TFTRs! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #76358, a change was made to consider both partitioning and
hash-shard columns as implicit, which was required for finding arbiters
for UPSERT statements in tables that have partitioned, hash-sharded
primary indexes. A side-effect of this change is that it prevents the
planning of the fast-path of UPSERTs into tables with hash-sharded
primary indexes. This commit fixes this regression.
Release justification: This fixes a performance regression for
hash-sharded indexes, which are being released as non-experimental in
the upcoming release.
There is no release note because this regression is not present in any
releases.
Release note: None