kv: use IsSingleHeartbeatTxnRequest method in admission control#77615
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 11, 2022
Merged
kv: use IsSingleHeartbeatTxnRequest method in admission control#77615craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit replaces the ad-hoc `isSingleHeartbeatTxnRequest` function defined in `kvserver/store.go` and called in `AdmitKVWork` with a call to the existing `(*BatchRequest).IsSingleHeartbeatTxnRequest` method. Release note: None. Release justification: Minor cleanup.
Member
|
This change is |
erikgrinaker
approved these changes
Mar 10, 2022
sumeerbhola
approved these changes
Mar 10, 2022
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Contributor
Author
|
bors r+ |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the ad-hoc
isSingleHeartbeatTxnRequestfunctiondefined in
kvserver/store.goand called inAdmitKVWorkwith a callto the existing
(*BatchRequest).IsSingleHeartbeatTxnRequestmethod.Release note: None.
Release justification: Minor cleanup.