dashboards: switch flushes/compactions graphs to bytes written#77558
dashboards: switch flushes/compactions graphs to bytes written#77558craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
This change is |
jbowens
left a comment
There was a problem hiding this comment.
love it
I'm wondering whether we should also throw ingested-bytes somewhere on this dashboard, maybe in the same graph as flushes. It would be nice to be able to quickly view bytes being added to the LSM.
Reviewed all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @petermattis)
➕
I didn't see any examples of multi-metric and per-node graphs, but maybe I didn't look hard enough. |
Done.
|
Release note (ui change): The Flushes/Compactions graph on the Storage metrics Dashboard now shows bytes written by these operations, and has been split into separate graphs which are each per-node.
Release note: none.
|
@jbowens you okay with the additional separate graph for ingestions? I asked in slack if we ever did multi-metric per-node graphs and and @dhartunian confirmed that we don't, so I think it'd be a separate graph if we want it (and want to keep flushes and it per-node, which I think we do?) |
|
@dt yeah, separate graph works 👍 |
|
Perfect. TFTR! bors r=jbowens |
|
Build succeeded: |
Release note (ui change): The Flushes/Compactions graph on the Storage metrics Dashboard now shows bytes written by these operations, and has been split into separate graphs which are each per-node.
Release justification: low risk, seems useful (we've frequently wished we had it in escalations from prior versions)