sql: ensure GC tenant removes system span configurations#77492
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 8, 2022
Merged
sql: ensure GC tenant removes system span configurations#77492craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
adityamaru
approved these changes
Mar 8, 2022
irfansharif
approved these changes
Mar 8, 2022
This patch ensures that when a tenant is removed, all system span configurations installed by it are also deleted from KV. This is in addition to removing all tenant reconciled span configurations that already happens. The patch adds a test to check for the latter as well. Fixes cockroachdb#76931 Release justification: bug fixes and low risk updates to new functionality Release note: None
dad7876 to
719e950
Compare
Collaborator
Author
|
TFTRs! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that when a tenant is removed, all system span
configurations installed by it are also deleted from KV. This is in
addition to removing all tenant reconciled span configurations that
already happens. The patch adds a test to check for the latter as
well.
Fixes #76931
Release justification: bug fixes and low risk updates to new
functionality
Release note: None