Reviewed 16 of 17 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @e-mbrown, @msbutler, and @rafiss)

pkg/ccl/backupccl/restore_planning.go, line 872 at r1 (raw file):

		}
		if err := b.RunPostDeserializationChanges(); err != nil {
			return err

can you wrap this with an assertion failure and note that it's running PostDeserializationChanges?

pkg/sql/catalog/descriptor.go, line 78 at r1 (raw file):

	// RunPostDeserializationChanges attempts to perform changes to the descriptor
	// being built from a deserialized protobuf.
	RunPostDeserializationChanges() error

Please note that any error should be treated an assertion failure and indicates corruption.

pkg/sql/catalog/descs/kv_descriptors.go, line 247 at r1 (raw file):

		b := desc.NewBuilder()
		if err := b.RunPostDeserializationChanges(); err != nil {
			return nil, err

can you wrap this with an assertion failure and note that it's running PostDeserializationChanges?

pkg/sql/catalog/internal/catkv/catalog_query.go, line 207 at r1 (raw file):

	}
	if err := b.RunPostDeserializationChanges(); err != nil {
		return nil, err

can you wrap this with an assertion failure and note that it's running PostDeserializationChanges?

pkg/sql/catalog/systemschema/system.go, line 800 at r1 (raw file):

	if err := b.RunPostDeserializationChanges(); err != nil {
		log.Fatalf(
			ctx, "System table %q cannot be registered, error during RunPostDeserializationChanges: %+v",

nit: message shouldn't be capitalized.

pkg/sql/doctor/doctor.go, line 85 at r1 (raw file):

		if b != nil {
			if err := b.RunPostDeserializationChanges(); err != nil {
				return nil, err

can you wrap this?

pkg/sql/doctor/doctor.go, line 98 at r1 (raw file):

		b := desc.NewBuilder()
		if err := b.RunPostDeserializationChanges(); err != nil {
			return nil, err

can you wrap this?

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @e-mbrown, and @msbutler)

pkg/ccl/backupccl/restore_planning.go, line 872 at r1 (raw file):

Done.

pkg/sql/catalog/descriptor.go, line 78 at r1 (raw file):

Done.

pkg/sql/catalog/descs/kv_descriptors.go, line 247 at r1 (raw file):

Done.

pkg/sql/catalog/internal/catkv/catalog_query.go, line 207 at r1 (raw file):

Done.

pkg/sql/catalog/systemschema/system.go, line 800 at r1 (raw file):

fixed this one and the existing one above

pkg/sql/doctor/doctor.go, line 85 at r1 (raw file):

Done.

pkg/sql/doctor/doctor.go, line 98 at r1 (raw file):

Done.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @e-mbrown and @msbutler)