ui: change invalid lease to expired lease on problem ranges page#76757
ui: change invalid lease to expired lease on problem ranges page#76757craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
koorosh
left a comment
There was a problem hiding this comment.
@Santamaura , is it necessary to rename forth column in the table as well?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @Annebirzin, @thtruo, and @zachlite)
When browsing the problem ranges page and invalid leases appears customers regularly are concerned with this status as they interpret it as something with the cluster is wrong which is often not the case. In order to imrpove this, the invalid lease section has been changed to expired lease and there is a description added below which explains that this status is often not a cause for concern. Release note (ui change): change invalid lease to expired lease on problem ranges page
937496e to
e0de475
Compare
Santamaura
left a comment
There was a problem hiding this comment.
Yes thanks for pointing that out. I've updated the column title as well.
Reviewable status:
koorosh
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Annebirzin
left a comment
There was a problem hiding this comment.
Reviewable status:
When browsing the problem ranges page and invalid leases appears customers
regularly are concerned with this status as they interpret it as something
with the cluster is wrong which is often not the case. In order to imrpove this,
the invalid lease section has been changed to expired lease and there is a
description added below which explains that this status is often not a cause
for concern.
Release note (ui change): change invalid lease to expired lease on problem ranges page
Resolves: #38616