kvserver: test that RangeFeed unaffected by Replica circuit breaker#76732
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 17, 2022
Merged
kvserver: test that RangeFeed unaffected by Replica circuit breaker#76732craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
erikgrinaker
approved these changes
Feb 17, 2022
`RangeFeed`s are long-running operations with a high fixed cost (catch-up scan). They can fall behind for various reasons, replicas becoming unavailable being one of them. However, when a replica's circuit breaker trips, this should not abort any pending (or new, for that matter) RangeFeeds. Add a test that asserts that this is the case. Touches cockroachdb#33007. Touches cockroachdb#76146. Release note: None
7c7a259 to
0233176
Compare
Member
Author
|
TFTR! bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RangeFeeds are long-running operations with a high fixed cost(catch-up scan). They can fall behind for various reasons, replicas
becoming unavailable being one of them. However, when a replica's
circuit breaker trips, this should not abort any pending (or new, for
that matter) RangeFeeds.
Add a test that asserts that this is the case.
Touches #33007.
Touches #76146.
Release note: None