Skip to content

backup: move resolution from planning to exec#76670

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
dt:backup-planning
Feb 18, 2022
Merged

backup: move resolution from planning to exec#76670
craig[bot] merged 2 commits intocockroachdb:masterfrom
dt:backup-planning

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Feb 16, 2022

Release note (ops change): the cluster setting bulkio.backup.resolve_destination_in_job.enabled can be used to delay resolution of backup's destination until the job starts running.

@dt dt requested review from adityamaru and stevendanna February 16, 2022 13:59
@dt dt requested a review from a team as a code owner February 16, 2022 13:59
@dt dt requested a review from a team February 16, 2022 13:59
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 16, 2022

my plan is to fast-follow removing the cluster setting and just version-gate instead, but using the setting initially for ease of backport when/if we decide that is a good idea.

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 16, 2022

@ajwerner you able to take a look at the job adoption fix in first commit?

@shermanCRL shermanCRL removed the request for review from a team February 16, 2022 14:13
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit LGTM, but could benefit from a test

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 16, 2022

could benefit from a test

BACKUP tests, nearly all of them that use schedules, fail without it after the second commit, so it is covered, just didn't see a easy exiting test to extend for targeted coverage, thus including it here rather than its own PR.

@dt dt force-pushed the backup-planning branch from c94902e to caa227c Compare February 17, 2022 05:03
dt added 2 commits February 17, 2022 15:04
Release note (ops change): the cluster setting bulkio.backup.resolve_destination_in_job.enabled can be used to delay resolution of backup's destination until the job starts running.
@dt dt force-pushed the backup-planning branch from caa227c to c017ccb Compare February 17, 2022 15:04
@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 17, 2022

@ajwerner actually, that ended up really easy to test, added 415dc1a#diff-5584d9441c078735c97a5b2b11007753c943dbb959afa049a3a5c22e884e59a3

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate it.

Reviewed 1 of 1 files at r1, 3 of 3 files at r3.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @ajwerner, and @stevendanna)

@dt dt requested review from miretskiy and removed request for adityamaru February 18, 2022 14:04
@miretskiy miretskiy requested a review from ajwerner February 18, 2022 20:34
Copy link
Copy Markdown
Contributor

@miretskiy miretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @stevendanna)

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 18, 2022

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 18, 2022

Build succeeded:

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 19, 2022

blathers backport 21.2

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Feb 19, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 415dc1a to blathers/backport-release-21.2-76670: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants