backup: move resolution from planning to exec#76670
backup: move resolution from planning to exec#76670craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
my plan is to fast-follow removing the cluster setting and just version-gate instead, but using the setting initially for ease of backport when/if we decide that is a good idea. |
|
@ajwerner you able to take a look at the job adoption fix in first commit? |
ajwerner
left a comment
There was a problem hiding this comment.
First commit LGTM, but could benefit from a test
BACKUP tests, nearly all of them that use schedules, fail without it after the second commit, so it is covered, just didn't see a easy exiting test to extend for targeted coverage, thus including it here rather than its own PR. |
Release note: none.
Release note (ops change): the cluster setting bulkio.backup.resolve_destination_in_job.enabled can be used to delay resolution of backup's destination until the job starts running.
|
@ajwerner actually, that ended up really easy to test, added 415dc1a#diff-5584d9441c078735c97a5b2b11007753c943dbb959afa049a3a5c22e884e59a3 |
ajwerner
left a comment
There was a problem hiding this comment.
I appreciate it.
Reviewed 1 of 1 files at r1, 3 of 3 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @ajwerner, and @stevendanna)
miretskiy
left a comment
There was a problem hiding this comment.
Reviewed 2 of 4 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @stevendanna)
|
TFTR! bors r+ |
|
Build succeeded: |
|
blathers backport 21.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 415dc1a to blathers/backport-release-21.2-76670: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Release note (ops change): the cluster setting bulkio.backup.resolve_destination_in_job.enabled can be used to delay resolution of backup's destination until the job starts running.