Skip to content

sql: move txnidcache's sync.Pool to be global variable#76418

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
Azhng:txn-id-cleanup-sync
Feb 16, 2022
Merged

sql: move txnidcache's sync.Pool to be global variable#76418
craig[bot] merged 1 commit intocockroachdb:masterfrom
Azhng:txn-id-cleanup-sync

Conversation

@Azhng
Copy link
Copy Markdown
Contributor

@Azhng Azhng commented Feb 11, 2022

Follow up to #76350


Release Note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@Azhng Azhng requested a review from ajwerner February 14, 2022 17:30
@Azhng Azhng marked this pull request as ready for review February 14, 2022 17:30
@Azhng Azhng requested a review from a team February 14, 2022 17:31
@Azhng Azhng force-pushed the txn-id-cleanup-sync branch from ee8d8f3 to a4a1aa9 Compare February 14, 2022 17:32
Copy link
Copy Markdown

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been lurking in your other conversations. This :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@Azhng Azhng force-pushed the txn-id-cleanup-sync branch 2 times, most recently from fde6bb0 to dc2302d Compare February 15, 2022 23:37
@Azhng Azhng force-pushed the txn-id-cleanup-sync branch from dc2302d to cadf94e Compare February 16, 2022 01:37
@craig craig bot merged commit cadf94e into cockroachdb:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants