sql: show actual primary index name in diagrams#76406
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 11, 2022
Merged
sql: show actual primary index name in diagrams#76406craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
yuzefovich
reviewed
Feb 11, 2022
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 3 of 32 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
mgartner
approved these changes
Feb 11, 2022
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status:
Currently the diagrams use a hardcoded `primary` for the primary index. This commit fixes this to use the actual name of the index. This will make switching to IndexFetchSpec easier. Release note: None
717925f to
b3ae6c5
Compare
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the diagrams use a hardcoded
primaryfor the primaryindex. This commit fixes this to use the actual name of the index.
This will make switching to IndexFetchSpec easier.
Release note: None